Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding existence check for this.canvas on object stacking mixins #6207

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Adding existence check for this.canvas on object stacking mixins #6207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d35b3f
Adding existence check for this.canvas on object stacking methods
paulconlin Mar 6, 2020
dbd8bb9
Fix my dumb mistake
paulconlin Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/mixins/object_stacking.mixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ fabric.util.object.extend(fabric.Object.prototype, /** @lends fabric.Object.prot
if (this.group) {
fabric.StaticCanvas.prototype.sendToBack.call(this.group, this);
}
else {
else if (this.canvas) {
this.canvas.sendToBack(this);
}
return this;
Expand All @@ -24,7 +24,7 @@ fabric.util.object.extend(fabric.Object.prototype, /** @lends fabric.Object.prot
if (this.group) {
fabric.StaticCanvas.prototype.bringToFront.call(this.group, this);
}
else {
else if (this.canvas) {
this.canvas.bringToFront(this);
}
return this;
Expand All @@ -40,7 +40,7 @@ fabric.util.object.extend(fabric.Object.prototype, /** @lends fabric.Object.prot
if (this.group) {
fabric.StaticCanvas.prototype.sendBackwards.call(this.group, this, intersecting);
}
else {
else if (this.canvas) {
this.canvas.sendBackwards(this, intersecting);
}
return this;
Expand All @@ -56,7 +56,7 @@ fabric.util.object.extend(fabric.Object.prototype, /** @lends fabric.Object.prot
if (this.group) {
fabric.StaticCanvas.prototype.bringForward.call(this.group, this, intersecting);
}
else {
else if (this.canvas) {
this.canvas.bringForward(this, intersecting);
}
return this;
Expand All @@ -72,7 +72,7 @@ fabric.util.object.extend(fabric.Object.prototype, /** @lends fabric.Object.prot
if (this.group && this.group.type !== 'activeSelection') {
fabric.StaticCanvas.prototype.moveTo.call(this.group, this, index);
}
else {
else if (this.canvas) {
this.canvas.moveTo(this, index);
}
return this;
Expand Down