Test interaction fix for android #6224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deodad
pushed a commit
to pervino/fabric.js
that referenced
this pull request
Apr 7, 2020
…tion on android keyboards (fabricjs#6224)
deodad
pushed a commit
to pervino/fabric.js
that referenced
this pull request
Apr 7, 2020
…tion on android keyboards (fabricjs#6224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like that android latest versions when the keyboard has suggestions enabled ( default setting ) will set the textarea in composition mode all the time.
This will stop any click action on the textarea for how the fabricjs code is written.
This is an attempt to find a working solution that does not break chinese/japanese and let people use android.