-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IText): regain focus on mouse move #8179
Conversation
Code Coverage Summary
|
We need to backport this to 5.x too |
To be clear #3759 was as hacky as this newer fix. |
@@ -398,6 +398,9 @@ import { removeFromArray } from '../util/internals'; | |||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is why it is more solid
focusing will trigger only if in editing mode and after mousedown
why are we putting effort into v5? |
fixes fabricjs#8177 caused by fabricjs#3759 and fixes fabricjs#3661 that was the motivation for fabricjs#3759 This issue was caused because the hiddenTextarea looses focus after mousedown. So I have added a focus call in mousemove that fixes both issues.
fixes #8177 caused by #3759 (that was hacky) and fixes #3661 that was the motivation for #3759
This issue was caused because the hiddenTextarea looses focus after mousedown.
So I have added a focus call in mousemove that fixes both issues.