Add a option to make deprecated input args visible #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caught us out, as when we removed a deprecated input arg is wasn't as visible as we'd have liked. By adding this option, we can have visiblity of deprecated input args.
|
@fabsrc Hello Fabian, could you please have a look at this PR. Thanks |
|
Thank you
I've added a couple tests. They're a bit more complicated than some of the others, as the option only affects |
fabsrc
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caught us out, as when we removed a deprecated input arg is wasn't as visible as we'd have liked.
By adding this option, we can have visibility of deprecated input args.
Opening as draft, as I think one of my colleagues wants to check it for themselves.✅