Skip to content

Commit

Permalink
load aux experiments with skip_runners_and_metrics=True
Browse files Browse the repository at this point in the history
Summary:
Load aux experiments with `skip_runners_and_metrics=True` by default.

meta: when an exp is saved with application specific (e.g., PTS) encoder, trying to load metrics with the generic FBDecoder (and OSS one probably as well) will result in fail to load metric error.

Differential Revision: D62661185
  • Loading branch information
ItsMrLin authored and facebook-github-bot committed Sep 13, 2024
1 parent ca2a720 commit 360b012
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion ax/storage/sqa_store/decoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ def _auxiliary_experiments_by_purpose_from_experiment_sqa(
for aux_exp_name in aux_exp_names:
auxiliary_experiments_by_purpose[aux_exp_purpose].append(
AuxiliaryExperiment(
experiment=load_experiment(aux_exp_name, config=self.config)
experiment=load_experiment(
aux_exp_name,
config=self.config,
skip_runners_and_metrics=True,
)
)
)
return auxiliary_experiments_by_purpose
Expand Down
2 changes: 1 addition & 1 deletion ax/storage/sqa_store/load.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def load_experiment(
config: `SQAConfig`, from which to retrieve the decoder. Optional,
defaults to base `SQAConfig`.
reduced_state: Whether to load experiment with a slightly reduced state
(without abandoned arms on experiment and withoug model state,
(without abandoned arms on experiment and without model state,
search space, and optimization config on generator runs).
skip_runners_and_metrics: If True skip loading runners, and do only a
minimal load of metrics. This option is intended to enable loading of
Expand Down

0 comments on commit 360b012

Please sign in to comment.