Make it possible to infer noise #1345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39413742 |
dme65
pushed a commit
to dme65/Ax
that referenced
this pull request
Dec 28, 2022
Summary: Pull Request resolved: facebook#1345 We currently set the noise to 0 for all benchmark problems even though we often infer the noise in practice. This diff adds an `infer_noise` flag that we can use to control whether different problems should set the noise to a fixed value or `None`, where the latter will trigger inferring the noise in the model. I'm setting `infer_noise=True` by default for all problems. Reviewed By: Balandat Differential Revision: D39413742 fbshipit-source-id: bdbe81048008b346f22d82552fb2a0074a1b1207
dme65
force-pushed
the
export-D39413742
branch
from
671d53d
to
20e868b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39413742 |
dme65
pushed a commit
to dme65/Ax
that referenced
this pull request
Dec 28, 2022
Summary: Pull Request resolved: facebook#1345 We currently set the noise to 0 for all benchmark problems even though we often infer the noise in practice. This diff adds an `infer_noise` flag that we can use to control whether different problems should set the noise to a fixed value or `None`, where the latter will trigger inferring the noise in the model. I'm setting `infer_noise=True` by default for all problems. Reviewed By: saitcakmak, Balandat Differential Revision: D39413742 fbshipit-source-id: 844960e3ab90c19b14c3615b3d91aceea60f2930
dme65
force-pushed
the
export-D39413742
branch
from
20e868b
to
9a2ee0a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39413742 |
Codecov ReportBase: 94.67% // Head: 94.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1345 +/- ##
==========================================
- Coverage 94.67% 94.67% -0.01%
==========================================
Files 420 420
Lines 38562 38565 +3
==========================================
+ Hits 36508 36510 +2
- Misses 2054 2055 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Summary: Pull Request resolved: facebook#1345 We currently set the noise to 0 for all benchmark problems even though we often infer the noise in practice. This diff adds an `infer_noise` flag that we can use to control whether different problems should set the noise to a fixed value or `None`, where the latter will trigger inferring the noise in the model. I'm setting `infer_noise=True` by default for all problems. Reviewed By: saitcakmak, Balandat Differential Revision: D39413742 fbshipit-source-id: e50ea9d684411a5da09d06899b1a11dac9aca3b3
dme65
force-pushed
the
export-D39413742
branch
from
9a2ee0a
to
044095a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39413742 |
|
This pull request has been merged in 9b8df90. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We currently set the noise to 0 for all benchmark problems even though we often infer the noise in practice. This diff adds an
infer_noiseflag that we can use to control whether different problems should set the noise to a fixed value orNone, where the latter will trigger inferring the noise in the model. I'm settinginfer_noise=Trueby default for all problems.Reviewed By: Balandat
Differential Revision: D39413742