Even more fixes to unused kwargs #1782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48338443 |
sdaulton
pushed a commit
to sdaulton/Ax-1
that referenced
this pull request
Aug 15, 2023
Summary: Pull Request resolved: facebook#1782 X-link: pytorch/botorch#1985 See previous diff Differential Revision: D48338443 fbshipit-source-id: 9053999cb34b616c0eca8ae9994ee6534212391c
sdaulton
pushed a commit
to sdaulton/botorch
that referenced
this pull request
Aug 15, 2023
Summary: X-link: facebook/Ax#1782 Pull Request resolved: pytorch#1985 See previous diff Differential Revision: D48338443 fbshipit-source-id: daff75e433cc1732e4e8c702eab87195ea9ea024
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 16, 2023
Summary: X-link: facebook/Ax#1782 Pull Request resolved: pytorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: 7cacc33ead6d5471855364eff910031640bc4708
|
This pull request was exported from Phabricator. Differential Revision: D48338443 |
esantorella
force-pushed
the
export-D48338443
branch
from
f2f81bf
to
86cb356
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 16, 2023
Summary: Pull Request resolved: facebook#1782 X-link: pytorch/botorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: 5231d7bfe20eacffaf15e029657ede64e397c037
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 16, 2023
Summary: X-link: facebook/Ax#1782 Pull Request resolved: pytorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: 3bb4762ae6a2a6997aff986a7fad1b2dc7391a8e
|
This pull request was exported from Phabricator. Differential Revision: D48338443 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 16, 2023
Summary: Pull Request resolved: facebook#1782 X-link: pytorch/botorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: 314fc711a4a59ce72035028bbe89d4c449f966ca
esantorella
force-pushed
the
export-D48338443
branch
from
86cb356
to
10f0a33
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1782 +/- ##
=======================================
Coverage 94.55% 94.55%
=======================================
Files 454 454
Lines 42643 42643
=======================================
Hits 40322 40322
Misses 2321 2321
☔ View full report in Codecov by Sentry. |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
Summary: X-link: facebook/Ax#1782 Pull Request resolved: pytorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: ff3ba0cae043e555d4957505ed35ad2bdb54411d
|
This pull request was exported from Phabricator. Differential Revision: D48338443 |
esantorella
force-pushed
the
export-D48338443
branch
from
10f0a33
to
fe2af4c
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
Summary: Pull Request resolved: facebook#1782 X-link: pytorch/botorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: b0dddbd9ef1a4f95eb862d567afa28f430e1f3b4
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
Summary: X-link: facebook/Ax#1782 Pull Request resolved: pytorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: 1ca14a55bf1e89b9c0d005b29d5ea7c7e16ee707
|
This pull request was exported from Phabricator. Differential Revision: D48338443 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
Summary: Pull Request resolved: facebook#1782 X-link: pytorch/botorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: 1e19efe7eb0504d61e0660dd57bacf07ba9366de
esantorella
force-pushed
the
export-D48338443
branch
from
fe2af4c
to
c3a5ef5
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
Summary: X-link: facebook/Ax#1782 Pull Request resolved: pytorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: e545697ad4f57c77388069a2b7531f2e5cb4f978
|
This pull request was exported from Phabricator. Differential Revision: D48338443 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
Summary: Pull Request resolved: facebook#1782 X-link: pytorch/botorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: 022be0195dc74475d38ec32a259a659838f633c1
esantorella
force-pushed
the
export-D48338443
branch
from
c3a5ef5
to
7811fac
Compare
Summary: Pull Request resolved: facebook#1782 X-link: pytorch/botorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: 857251059f06b856d5d31e25dfec236fc20543ec
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
Summary: X-link: facebook/Ax#1782 Pull Request resolved: pytorch#1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: 9be8248e069e6bf61c0e4bf999505d81640eefc1
|
This pull request was exported from Phabricator. Differential Revision: D48338443 |
esantorella
force-pushed
the
export-D48338443
branch
from
7811fac
to
3f79fd0
Compare
|
This pull request has been merged in c3f0cef. |
facebook-github-bot
pushed a commit
to pytorch/botorch
that referenced
this pull request
Aug 18, 2023
Summary: X-link: facebook/Ax#1782 Pull Request resolved: #1985 See previous diff Reviewed By: lena-kashtelyan Differential Revision: D48338443 fbshipit-source-id: f5f674fe224cf5a1ef06a6de9cdad10dfda09382
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Apr 4, 2024
Summary: Ax facebook#1782 removed usages of sequential=True where it was silently ignored. This didn't have an effect, or at least as of today it doesn't, because sequential is set to True by default. This PR adds tests to make sure "sequential" is being passed through appropriately. The exception is cases where optimize_acqf_list is used; optimize_acqf_list is inherently sequential and doesn't accept that argument. Differential Revision: D55772746
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Apr 4, 2024
facebook#2324) Summary: Ax facebook#1782 removed usages of sequential=True where it was silently ignored. This didn't have an effect, or at least as of today it doesn't, because sequential is set to True by default. This PR adds tests to make sure "sequential" is being passed through appropriately. The exception is cases where optimize_acqf_list is used; optimize_acqf_list is inherently sequential and doesn't accept that argument. Differential Revision: D55772746
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
#2324) Summary: Pull Request resolved: #2324 Ax #1782 removed usages of sequential=True where it was silently ignored. This didn't have an effect, or at least as of today it doesn't, because sequential is set to True by default. This PR adds tests to make sure "sequential" is being passed through appropriately. The exception is cases where optimize_acqf_list is used; optimize_acqf_list is inherently sequential and doesn't accept that argument. Reviewed By: saitcakmak Differential Revision: D55772746 fbshipit-source-id: d780334ecf87bec5d853d70ba46689ee4a107add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/botorch#1985
See previous diff
Differential Revision: D48338443