Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GenerationStrategyInterface with gen_multiple_with_ensembling() #1972

Closed

Conversation

danielcohenlive
Copy link

Reviewed By: lena-kashtelyan

Differential Revision: D50660266

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50660266

facebook#1972)

Summary: Pull Request resolved: facebook#1972

Reviewed By: lena-kashtelyan

Differential Revision: D50660266
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 9, 2023
facebook#1972)

Summary: Pull Request resolved: facebook#1972

Reviewed By: lena-kashtelyan

Differential Revision: D50660266
@danielcohenlive danielcohenlive force-pushed the export-D50660266 branch 2 times, most recently from 15f89a5 to 4d9804b Compare November 9, 2023 17:51
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50660266

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50660266

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (3b9b94b) 94.56% compared to head (1fb0a35) 94.45%.
Report is 1 commits behind head on main.

❗ Current head 1fb0a35 differs from pull request most recent head 4d9804b. Consider uploading reports for the commit 4d9804b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
- Coverage   94.56%   94.45%   -0.11%     
==========================================
  Files         459      460       +1     
  Lines       43863    43914      +51     
==========================================
  Hits        41479    41479              
- Misses       2384     2435      +51     
Files Coverage Δ
ax/core/generation_strategy_interface.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 82f6f88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants