Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update BestPointMixin to support BatchTrial in benchmarks #2014

Closed
wants to merge 1 commit into from
Closed

update BestPointMixin to support BatchTrial in benchmarks #2014

wants to merge 1 commit into from

Conversation

sdaulton
Copy link
Contributor

Summary: see title

Differential Revision: D51534384

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 22, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51534384

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Nov 22, 2023
@sdaulton @facebook-github-bot
update BestPointMixin to support BatchTrial in benchmarks (facebook#2014
1a39708 
)

Summary:

see title

Differential Revision: D51534384
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51534384

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Nov 29, 2023
@sdaulton @facebook-github-bot
update BestPointMixin to support BatchTrial in benchmarks (facebook#2014
7d68e2c 
)

Summary:

see title

Reviewed By: esantorella

Differential Revision: D51534384
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51534384

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9efacba) 94.52% compared to head (b920b26) 94.52%.

❗ Current head b920b26 differs from pull request most recent head 1bb6df0. Consider uploading reports for the commit 1bb6df0 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2014   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         460      460           
  Lines       44478    44522   +44     
=======================================
+ Hits        42042    42085   +43     
- Misses       2436     2437    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Nov 29, 2023
@sdaulton @facebook-github-bot
update BestPointMixin to support BatchTrial in benchmarks (facebook#2014
fc20d4f 
)

Summary:

see title

Reviewed By: esantorella

Differential Revision: D51534384
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51534384

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Nov 29, 2023
@sdaulton @facebook-github-bot
update BestPointMixin to support BatchTrial in benchmarks (facebook#2014
61f3746 
)

Summary:

see title

Reviewed By: esantorella

Differential Revision: D51534384
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51534384

@sdaulton @facebook-github-bot
update BestPointMixin to support BatchTrial in benchmarks (facebook#2014
1bb6df0 
)

Summary:

see title

Reviewed By: esantorella

Differential Revision: D51534384
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51534384

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 79133c7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdaulton @facebook-github-bot @codecov-commenter