Replace get_generator_run_limit function on GenerationStep with new method on GenerationNode #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51169425 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
…ethod on GenerationNode (facebook#2018) Summary: This diff does the following: Replaces the `get_generator_run_limit()` method on GenerationStep with `generator_run_limit` on GenerationNode. The new method relies on transition criterion to determine the number of generator runs, and only checks criterion that are trial based. I actually think this may not need to be expanded because the trial based criterion seem the most related to new generator run creation, but it could be expanded easily in the future if a usecase requires doing so. upcoming: (0) Finish removing GenerationStep methods in (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51169425
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2018 +/- ##
==========================================
- Coverage 94.53% 94.50% -0.04%
==========================================
Files 460 460
Lines 44310 44331 +21
==========================================
+ Hits 41890 41896 +6
- Misses 2420 2435 +15 ☔ View full report in Codecov by Sentry. |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
…ethod on GenerationNode (facebook#2018) Summary: This diff does the following: Replaces the `get_generator_run_limit()` method on GenerationStep with `generator_run_limit` on GenerationNode. The new method relies on transition criterion to determine the number of generator runs, and only checks criterion that are trial based. I actually think this may not need to be expanded because the trial based criterion seem the most related to new generator run creation, but it could be expanded easily in the future if a usecase requires doing so. upcoming: (0) Finish removing GenerationStep methods in (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51169425
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
…ethod on GenerationNode (facebook#2018) Summary: This diff does the following: Replaces the `get_generator_run_limit()` method on GenerationStep with `generator_run_limit` on GenerationNode. The new method relies on transition criterion to determine the number of generator runs, and only checks criterion that are trial based. I actually think this may not need to be expanded because the trial based criterion seem the most related to new generator run creation, but it could be expanded easily in the future if a usecase requires doing so. upcoming: (0) Finish removing GenerationStep methods in (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51169425
…ethod on GenerationNode (facebook#2018) Summary: This diff does the following: Replaces the `get_generator_run_limit()` method on GenerationStep with `generator_run_limit` on GenerationNode. The new method relies on transition criterion to determine the number of generator runs, and only checks criterion that are trial based. I actually think this may not need to be expanded because the trial based criterion seem the most related to new generator run creation, but it could be expanded easily in the future if a usecase requires doing so. upcoming: (0) Finish removing GenerationStep methods in (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51169425
mgarrard
force-pushed
the
export-D51169425
branch
from
9cff797
to
b723ec0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51169425 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
…ethod on GenerationNode (facebook#2018) Summary: This diff does the following: Replaces the `get_generator_run_limit()` method on GenerationStep with `generator_run_limit` on GenerationNode. The new method relies on transition criterion to determine the number of generator runs, and only checks criterion that are trial based. I actually think this may not need to be expanded because the trial based criterion seem the most related to new generator run creation, but it could be expanded easily in the future if a usecase requires doing so. upcoming: (0) Finish removing GenerationStep methods in (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51169425
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
…ethod on GenerationNode (facebook#2018) Summary: This diff does the following: Replaces the `get_generator_run_limit()` method on GenerationStep with `generator_run_limit` on GenerationNode. The new method relies on transition criterion to determine the number of generator runs, and only checks criterion that are trial based. I actually think this may not need to be expanded because the trial based criterion seem the most related to new generator run creation, but it could be expanded easily in the future if a usecase requires doing so. upcoming: (0) Finish removing GenerationStep methods in (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51169425
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
…ethod on GenerationNode (facebook#2018) Summary: This diff does the following: Replaces the `get_generator_run_limit()` method on GenerationStep with `generator_run_limit` on GenerationNode. The new method relies on transition criterion to determine the number of generator runs, and only checks criterion that are trial based. I actually think this may not need to be expanded because the trial based criterion seem the most related to new generator run creation, but it could be expanded easily in the future if a usecase requires doing so. upcoming: (0) Finish removing GenerationStep methods in (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51169425
|
This pull request has been merged in 66dd7df. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff does the following:
Replaces the
get_generator_run_limit()method on GenerationStep withgenerator_run_limiton GenerationNode. The new method relies on transition criterion to determine the number of generator runs, and only checks criterion that are trial based. I actually think this may not need to be expanded because the trial based criterion seem the most related to new generator run creation, but it could be expanded easily in the future if a usecase requires doing so.upcoming:
(0) Finish removing GenerationStep methods in
(1) delete functions from GenStep that aren't needed anymore
(2) update the storage to include nodes independently (and not just as part of step)
(3) final pass on all the doc strings
(4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode
(5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed
(6) rename transiton criterion to action criterion
Reviewed By: lena-kashtelyan
Differential Revision: D51169425