Add extract_pending_observations function that auto-deploys to the correct pending-points function for the use case
#2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51684966 |
lena-kashtelyan
force-pushed
the
export-D51684966
branch
from
057644b
to
e777720
Compare
lena-kashtelyan
added a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Dec 5, 2023
…correct pending-points function for the use case (facebook#2039) Summary: For automated extraction of pending points, it would be ideal to not have to separately call one of two functions: get_pending... and get_pending_..._based_on_trial_status. I think we only want to go the latter route when: all trials are 1-arm and there are many trials. Planning to use this for pending points extraction from within the ExternalGenerationStrategy (in time we might use this in other places, too, e.g. the Scheduler). Differential Revision: D51684966
|
This pull request was exported from Phabricator. Differential Revision: D51684966 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2039 +/- ##
==========================================
- Coverage 94.52% 94.52% -0.01%
==========================================
Files 460 460
Lines 44522 44543 +21
==========================================
+ Hits 42086 42105 +19
- Misses 2436 2438 +2 ☔ View full report in Codecov by Sentry. |
lena-kashtelyan
added a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Dec 6, 2023
…correct pending-points function for the use case (facebook#2039) Summary: For automated extraction of pending points, it would be ideal to not have to separately call one of two functions: get_pending... and get_pending_..._based_on_trial_status. I think we only want to go the latter route when: all trials are 1-arm and there are many trials. Planning to use this for pending points extraction from within the ExternalGenerationStrategy (in time we might use this in other places, too, e.g. the Scheduler). Differential Revision: D51684966
lena-kashtelyan
force-pushed
the
export-D51684966
branch
from
e777720
to
999b7c3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51684966 |
lena-kashtelyan
added a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Dec 6, 2023
…correct pending-points function for the use case (facebook#2039) Summary: For automated extraction of pending points, it would be ideal to not have to separately call one of two functions: get_pending... and get_pending_..._based_on_trial_status. I think we only want to go the latter route when: all trials are 1-arm and there are many trials. Planning to use this for pending points extraction from within the ExternalGenerationStrategy (in time we might use this in other places, too, e.g. the Scheduler). Differential Revision: D51684966
lena-kashtelyan
force-pushed
the
export-D51684966
branch
from
999b7c3
to
06b49d0
Compare
…correct pending-points function for the use case (facebook#2039) Summary: Pull Request resolved: facebook#2039 For automated extraction of pending points, it would be ideal to not have to separately call one of two functions: get_pending... and get_pending_..._based_on_trial_status. I think we only want to go the latter route when: all trials are 1-arm and there are many trials. Planning to use this for pending points extraction from within the ExternalGenerationStrategy (in time we might use this in other places, too, e.g. the Scheduler). Differential Revision: D51684966 fbshipit-source-id: 4bc2ee0f8dfe69801cbc1da9d16bb8f3054390be
|
This pull request was exported from Phabricator. Differential Revision: D51684966 |
lena-kashtelyan
force-pushed
the
export-D51684966
branch
from
06b49d0
to
de6dda2
Compare
|
This pull request has been merged in c14ff08. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For automated extraction of pending points, it would be ideal to not have to separately call one of two functions: get_pending... and get_pending_..._based_on_trial_status. I think we only want to go the latter route when: all trials are 1-arm and there are many trials.
Planning to use this for pending points extraction from within the ExternalGenerationStrategy (in time we might use this in other places, too, e.g. the Scheduler).
Differential Revision: D51684966