New TB metric #2236
Closed
New TB metric #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53862120 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2236 +/- ##
==========================================
- Coverage 94.85% 94.84% -0.01%
==========================================
Files 467 467
Lines 46381 46472 +91
==========================================
+ Hits 43993 44078 +85
- Misses 2388 2394 +6 ☔ View full report in Codecov by Sentry. |
mpolson64
force-pushed
the
export-D53862120
branch
from
88da2ef
to
66da1a7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53862120 |
Summary: Created a new, massively simplified TB metric with the intention of reaping the old TensorboardCurveMetric. The new version has much shorter source, circumvents the bespoke logic in CurveMetric (by opting to hew closer to the vanilla MapMetric), does not need the "get_ids_from_trials" function, cleanly separates log-reading from curve processing, and supports bulk_fetch_trial_data. The new TensorboardMetric also has a new setting "smoothing" which emulates the behavior of the smoothing slider in the Tensorboard UI, which many users have requested. Also, "curve_name" has been renamed "tag" to better reflect Tensorboard terminology. Differential Revision: D53862120
mpolson64
force-pushed
the
export-D53862120
branch
from
66da1a7
to
cec5073
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53862120 |
|
This pull request has been merged in 810fe05. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Created a new, massively simplified TB metric with the intention of reaping the old TensorboardCurveMetric. The new version has much shorter source, circumvents the bespoke logic in CurveMetric (by opting to hew closer to the vanilla MapMetric), does not need the "get_ids_from_trials" function, cleanly separates log-reading from curve processing, and supports bulk_fetch_trial_data.
The new TensorboardMetric also has a new setting "smoothing" which emulates the behavior of the smoothing slider in the Tensorboard UI, which many users have requested.
Also, "curve_name" has been renamed "tag" to better reflect Tensorboard terminology.
Differential Revision: D53862120