ensure minimize is passed to make_experiment #2251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: D52846021 introduced a bug where `minimize` is ignored if `objective_name` is not provided. This rectifies. Differential Revision: D54559416
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54559416 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2251 +/- ##
=======================================
Coverage 94.86% 94.86%
=======================================
Files 467 467
Lines 46447 46449 +2
=======================================
+ Hits 44060 44062 +2
Misses 2387 2387 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 85768e8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: D52846021 introduced a bug where
minimizeis ignored ifobjective_nameis not provided. This rectifies.Differential Revision: D54559416