Unblock node based GS in AxClient.get_optimization_trace #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54974577 |
Summary: This would previously raise an `UnsupportedError` due to `model_transitions` being avaible only with step based GS. Differential Revision: D54974577
saitcakmak
force-pushed
the
export-D54974577
branch
from
1a86b7c
to
c0cda18
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54974577 |
|
This pull request has been merged in 3ed20ea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This would previously raise an
UnsupportedErrordue tomodel_transitionsbeing avaible only with step based GS.Differential Revision: D54974577