Silence input normalization warnings in cross validation #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: If we compute CV directly using `TorchModelBridge._cross_validate`, we skip the part of `ModelBridge.cross_validate` that silences these warnings. Replicated the same logic for CV computations in the untransformed space. Differential Revision: D55648398
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55648398 |
|
This pull request has been merged in 0014c75. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: If we compute CV directly using
TorchModelBridge._cross_validate, we skip the part ofModelBridge.cross_validatethat silences these warnings. Replicated the same logic for CV computations in the untransformed space.Differential Revision: D55648398