fix skip_runners_and_metrics for metrics on generator runs with mutable multi-objective optimization config #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le multi-objective optimization config Summary: This fixes load_experiment with `skip_runners_and_metricsmetrics` by setting properties SQAMetrics on generator runs that have multi-objective intent, for experiments with mutable optimization configs Reviewed By: Balandat Differential Revision: D55663714
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55663714 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2312 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 489 489
Lines 47763 47781 +18
=======================================
+ Hits 45333 45351 +18
Misses 2430 2430 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 8bc9553. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This fixes load_experiment with
skip_runners_and_metricsmetricsby setting properties SQAMetrics on generator runs that have multi-objective intent, for experiments with mutable optimization configsReviewed By: Balandat
Differential Revision: D55663714