Allow bulk_fetch_trial_data to return mix of successes/failures #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently bulk_fetch_trial_data (which we use for efficiency) will fail if any individual metric fetch fails. This can cause issues if Ax tries to fetch 2 metrics (say training loss and eval loss) and one is ready but the other is not. In the current setup Ax will report both as failures to fetch, in the new setup Ax will fetch the available one and return Err for the second Reviewed By: sunnyshen321 Differential Revision: D55927149
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55927149 |
|
This pull request has been merged in 6720be4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently bulk_fetch_trial_data (which we use for efficiency) will fail if any individual metric fetch fails. This can cause issues if Ax tries to fetch 2 metrics (say training loss and eval loss) and one is ready but the other is not. In the current setup Ax will report both as failures to fetch, in the new setup Ax will fetch the available one and return Err for the second
Reviewed By: sunnyshen321
Differential Revision: D55927149