Tests which store and load dataframe and figure #2344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff adds tests for CrossValidationPlot - Stores a json representation of the dataframe of the plot to a tempfile, then reads it back, and asserts equality - Converts the plot to a json object, converts it back, then checks equality. We'll need to store analysis objects, so we need to check that the dataframe and figures are serializable to json Differential Revision: D55967859
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55967859 |
|
This pull request has been merged in a3661fc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds tests for CrossValidationPlot
We'll need to store analysis objects, so we need to check that the dataframe and figures are serializable to json
Differential Revision: D55967859