Fix deprecation warning from pandas.read_json #2346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55978442 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 10, 2024
Summary: Addresses the following warning: ``` Passing literal json to 'read_json' is deprecated and will be removed in a future version. To read from a literal string, wrap it in a 'StringIO' object. ``` Seen in dev API tutorial: https://ax.dev/tutorials/gpei_hartmann_developer.html Differential Revision: D55978442
saitcakmak
force-pushed
the
export-D55978442
branch
from
b6eab1a
to
4c1a25d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55978442 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2346 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 491 491
Lines 47788 47867 +79
=======================================
+ Hits 45356 45434 +78
- Misses 2432 2433 +1 ☔ View full report in Codecov by Sentry. |
Summary: Addresses the following warning: ``` Passing literal json to 'read_json' is deprecated and will be removed in a future version. To read from a literal string, wrap it in a 'StringIO' object. ``` Seen in dev API tutorial: https://ax.dev/tutorials/gpei_hartmann_developer.html Reviewed By: mgarrard Differential Revision: D55978442
saitcakmak
force-pushed
the
export-D55978442
branch
from
4c1a25d
to
de2af43
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55978442 |
|
This pull request has been merged in 415f84d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Addresses the following warning:
Seen in dev API tutorial: https://ax.dev/tutorials/gpei_hartmann_developer.html
Differential Revision: D55978442