Make sure TestCase.setUp is executed in tests #2384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: The logger & warning filters in `TestCase.setUp` are only effective if it gets executed. Many test definitions were overwriting `setUp` without a `super().setUp()` call, ignoring these filters. Reviewed By: esantorella Differential Revision: D56375193
saitcakmak
force-pushed
the
export-D56375193
branch
from
2f7a16c
to
3a1d95d
Compare
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The logger & warning filters in
TestCase.setUpare only effective if it gets executed. Many test definitions were overwritingsetUpwithout asuper().setUp()call, ignoring these filters.Reviewed By: esantorella
Differential Revision: D56375193