Support multiple node generation for single trial #2428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56743651 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2428 +/- ##
==========================================
- Coverage 95.32% 95.32% -0.01%
==========================================
Files 496 496
Lines 48204 48326 +122
==========================================
+ Hits 45951 46065 +114
- Misses 2253 2261 +8 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D56743651 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
…acebook#2428) Summary: Pull Request resolved: facebook#2428 This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Differential Revision: D56743651
mgarrard
force-pushed
the
export-D56743651
branch
2 times, most recently
from
72d4dd3
to
bc76609
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
…acebook#2428) Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Differential Revision: D56743651
|
This pull request was exported from Phabricator. Differential Revision: D56743651 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
…acebook#2428) Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Differential Revision: D56743651
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
…acebook#2428) Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Differential Revision: D56743651
|
This pull request was exported from Phabricator. Differential Revision: D56743651 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
…acebook#2428) Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Differential Revision: D56743651
|
This pull request was exported from Phabricator. Differential Revision: D56743651 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
…acebook#2428) Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Differential Revision: D56743651
|
This pull request was exported from Phabricator. Differential Revision: D56743651 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
…acebook#2428) Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Differential Revision: D56743651
|
This pull request was exported from Phabricator. Differential Revision: D56743651 |
mgarrard
force-pushed
the
export-D56743651
branch
from
743b056
to
0d35aab
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 10, 2024
…acebook#2428) Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Differential Revision: D56743651
|
This pull request was exported from Phabricator. Differential Revision: D56743651 |
Summary: In order to support multiple models in a single gen call we need to support the `Auto` Transition class. This criterion will automatically move to the next node once anything has been generated from the current node Reviewed By: saitcakmak Differential Revision: D56360662
Summary: While I was working on adding some new tests I noticed we could be using the vars defined in setup much more in the file to reduce redundancy Reviewed By: lena-kashtelyan Differential Revision: D56744357
…acebook#2446) Summary: As part of modifying the generation node dag we want to support multiple transition edges now (meaning one node x could transition either to node y or node z depending on what criterion are met). This property creates a dict with {'next_node_name': [tc]} where tc is the transition criterion to move the gs from the current node to the `next node` The reason we need this, is currently and in any future i can envision, to transition to another node all criterion for that edge that are transition blocking must be met. In the next diff I modify the should_transition method. I just like bite sized diffs :) Reviewed By: lena-kashtelyan Differential Revision: D57127974
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Differential Revision: D57132018
…acebook#2428) Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Differential Revision: D56743651
mgarrard
force-pushed
the
export-D56743651
branch
from
0d35aab
to
0cabf69
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56743651 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 11, 2024
…acebook#2428) Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D56743651
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 14, 2024
…acebook#2428) Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff To do this we added: (1) should_move_trials method (2) updates to the transition criterion args Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D56743651
|
This pull request has been merged in 231d45d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that:
(1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff
(2) we don't support multiple transition criterion creating individual forks to another trial -- all trial blocking tc must be met in order to move to the next step --> we don't have a usecase for this right now, so i think it's okay to wait on this. The current implementation should be quite easy to extend to support this.
To do this we added:
(1) trial transitions property
(2) generation node dict property
(3) should_move_trials method
and (4) a temp gen method to derisk the dev
Differential Revision: D56743651