Improve error clarity in TensorboardMetric #2456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add specific error messages to tb fetching for when data is missing. Previously this would error out in a pandas operation which was confusing to many users. Now, we check to see whether the issue occurred because the tag was not present on the multiplexer at all (common) or because the tag was present but not data was found associated ie an empty tensor was attached (uncommon but possible). Differential Revision: D57342319
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57342319 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2456 +/- ##
==========================================
- Coverage 95.32% 95.31% -0.01%
==========================================
Files 496 496
Lines 48323 48328 +5
==========================================
+ Hits 46062 46064 +2
- Misses 2261 2264 +3 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in e6ab78c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add specific error messages to tb fetching for when data is missing.
Previously this would error out in a pandas operation which was confusing to many users. Now, we check to see whether the issue occurred because the tag was not present on the multiplexer at all (common) or because the tag was present but not data was found associated ie an empty tensor was attached (uncommon but possible).
Differential Revision: D57342319