change flag from supress_generation_errors to raise_generation_errors #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57477070 |
…facebook#2468) Summary: Cleans up an easy todo that adds additional clarity to one of the generation node methods where we make raising an error the exception as opposed to the expectation Differential Revision: D57477070
mgarrard
force-pushed
the
export-D57477070
branch
from
728cc8a
to
cde454d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57477070 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 485 485
Lines 47393 47393
=======================================
Hits 45147 45147
Misses 2246 2246 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 6558d27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Cleans up an easy todo that adds additional clarity to one of the generation node methods where we make raising an error the exception as opposed to the expectation
Differential Revision: D57477070