Fix equality check for floats #2507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58289519 |
|
This pull request was exported from Phabricator. Differential Revision: D58289519 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebook#2507 `same_elements()` wasn't working for `float('nan')`, and it wasn't treating floats with `np.is_close()` like in `object_attribute_dicts_find_unequal_fields()`. Also, `same_elements` was generally broken. Example: {F1676730235} Differential Revision: D58289519
danielcohenlive
force-pushed
the
export-D58289519
branch
from
4fa4ff8
to
166a950
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58289519 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebook#2507 `same_elements()` wasn't working for `float('nan')`, and it wasn't treating floats with `np.is_close()` like in `object_attribute_dicts_find_unequal_fields()`. Also, `same_elements` was generally broken. Example: {F1676730235} Differential Revision: D58289519
danielcohenlive
force-pushed
the
export-D58289519
branch
from
166a950
to
e8dcf8b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58289519 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebook#2507 `same_elements()` wasn't working for `float('nan')`, and it wasn't treating floats with `np.is_close()` like in `object_attribute_dicts_find_unequal_fields()`. Also, `same_elements` was generally broken. Example: {F1676730235} Differential Revision: D58289519
danielcohenlive
force-pushed
the
export-D58289519
branch
from
e8dcf8b
to
d99565c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58289519 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebook#2507 `same_elements()` wasn't working for `float('nan')`, and it wasn't treating floats with `np.is_close()` like in `object_attribute_dicts_find_unequal_fields()`. Also, `same_elements` was generally broken. Example: {F1676730235} Differential Revision: D58289519
danielcohenlive
force-pushed
the
export-D58289519
branch
from
d99565c
to
703f0e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2507 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 485 485
Lines 47406 47411 +5
=======================================
+ Hits 45171 45176 +5
Misses 2235 2235 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D58289519 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebook#2507 `same_elements()` wasn't working for `float('nan')`, and it wasn't treating floats with `np.is_close()` like in `object_attribute_dicts_find_unequal_fields()`. Also, `same_elements` was generally broken. Example: {F1676730235} Differential Revision: D58289519
danielcohenlive
force-pushed
the
export-D58289519
branch
from
703f0e3
to
31a9366
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58289519 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebook#2507 `same_elements()` wasn't working for `float('nan')`, and it wasn't treating floats with `np.is_close()` like in `object_attribute_dicts_find_unequal_fields()`. Also, `same_elements` was generally broken. Example: {F1676730235} Differential Revision: D58289519
danielcohenlive
force-pushed
the
export-D58289519
branch
from
31a9366
to
3663ab5
Compare
Summary: Pull Request resolved: facebook#2507 `same_elements()` wasn't working for `float('nan')`, and it wasn't treating floats with `np.is_close()` like in `object_attribute_dicts_find_unequal_fields()`. Also, `same_elements` was generally broken. Example: {F1676730235} Reviewed By: saitcakmak Differential Revision: D58289519
|
This pull request was exported from Phabricator. Differential Revision: D58289519 |
danielcohenlive
force-pushed
the
export-D58289519
branch
from
3663ab5
to
5e7357e
Compare
|
This pull request has been merged in 932746d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
same_elements()wasn't working forfloat('nan'), and it wasn't treating floats withnp.is_close()like inobject_attribute_dicts_find_unequal_fields().Also,
same_elementswas generally broken. Example:{F1676730235}
Differential Revision: D58289519