Fix pending point bug in ExternalGenerationNode #2521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58507833 |
Summary: Pull Request resolved: facebook#2521 This was passing a nested list, which was a bug. Reviewed By: saitcakmak Differential Revision: D58507833
|
This pull request was exported from Phabricator. Differential Revision: D58507833 |
Balandat
force-pushed
the
export-D58507833
branch
from
be9ce24
to
eacf27d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2521 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 485 485
Lines 47243 47263 +20
=======================================
+ Hits 44983 45003 +20
Misses 2260 2260 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 0b8e4db. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This was passing a nested list, which was a bug.
Differential Revision: D58507833