Avoid errors in telemetry due to node-based GenerationStrategy #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59193222 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2554 +/- ##
==========================================
- Coverage 95.22% 95.22% -0.01%
==========================================
Files 483 483
Lines 47228 47246 +18
==========================================
+ Hits 44972 44988 +16
- Misses 2256 2258 +2 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D59193222 |
Balandat
added a commit
to Balandat/Ax
that referenced
this pull request
Jul 1, 2024
…ook#2554) Summary: Pull Request resolved: facebook#2554 The Ax telemetry module currently assumes that `GenerationStrategy` objects are all step-based. This diff a warning and returns a dummy record for those cases to avoid errors with node-based GSs. The proper fix here is to fully support node-based GSs in telemetry, but that will be a bit more work it seems. Reviewed By: saitcakmak Differential Revision: D59193222
Balandat
force-pushed
the
export-D59193222
branch
from
b242169
to
0a32d5b
Compare
…ook#2554) Summary: Pull Request resolved: facebook#2554 The Ax telemetry module currently assumes that `GenerationStrategy` objects are all step-based. This diff a warning and returns a dummy record for those cases to avoid errors with node-based GSs. The proper fix here is to fully support node-based GSs in telemetry, but that will be a bit more work it seems. Reviewed By: saitcakmak Differential Revision: D59193222
|
This pull request was exported from Phabricator. Differential Revision: D59193222 |
Balandat
force-pushed
the
export-D59193222
branch
from
0a32d5b
to
5d728f6
Compare
|
This pull request has been merged in 83f23a4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The Ax telemetry module currently assumes that
GenerationStrategyobjects are all step-based. This diff a warning and returns a dummy record for those cases to avoid errors with node-based GSs.The proper fix here is to fully support node-based GSs in telemetry, but that will be a bit more work it seems.
Differential Revision: D59193222