Move ax/analysis to ax/analysis/old #2588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
After discussion between myself, lena-kashtelyan mgrange1998 and Cesar-Cardoso we decided to make a few small changes to the analysis module to make the data model simpler to understand in the context of storage considerations. See N5607609 for details and reasoning.
tldr:
* Analysis broken into Analysis (code for "how" a plot is to be generated) and AnalysisCard (the generated plot and its raw data)
* {AxClient, Scheduler}.generate_report will take in Iterable[Analysis] and return List[AnalysisCard], while emitting cards to DB if possible
* Misc module restructuring
In order to aid readability during review I will be moving existing code to ax/analysis/old rather than refactoring in place. Once the new structure is reviewed we can move the existing plots (parallel coordinates, predicted outcomes, cross validation) back into ax/analysis.
Differential Revision: D59925220
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59925220 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2588 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 489 489
Lines 47683 47683
=======================================
Hits 45406 45406
Misses 2277 2277 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 4f5f9a9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
After discussion between myself, lena-kashtelyan mgrange1998 and Cesar-Cardoso we decided to make a few small changes to the analysis module to make the data model simpler to understand in the context of storage considerations. See N5607609 for details and reasoning.
tldr:
In order to aid readability during review I will be moving existing code to ax/analysis/old rather than refactoring in place. Once the new structure is reviewed we can move the existing plots (parallel coordinates, predicted outcomes, cross validation) back into ax/analysis.
Differential Revision: D59925220