Delete ListSurrogate #2612
Closed
Delete ListSurrogate #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This has been deprecated for quite some time. We can safely remove it. I left the storage backwards compatibility code in-place. We can still load old `ListSurrogate` objects as a `Surrogate`. Reviewed By: dme65 Differential Revision: D60393343
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60393343 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 495 494 -1
Lines 47721 47719 -2
=======================================
- Hits 45436 45435 -1
+ Misses 2285 2284 -1 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 706d42a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This has been deprecated for quite some time. We can safely remove it.
I left the storage backwards compatibility code in-place. We can still load old
ListSurrogateobjects as aSurrogate.Reviewed By: dme65
Differential Revision: D60393343