Remove status quo weight override from COPY_DB_IDS_ATTRS_TO_SKIP #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60413211 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2615 +/- ##
==========================================
- Coverage 95.22% 95.22% -0.01%
==========================================
Files 492 492
Lines 47672 47692 +20
==========================================
+ Hits 45394 45413 +19
- Misses 2278 2279 +1 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D60413211 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jul 31, 2024
…ebook#2615) Summary: Pull Request resolved: facebook#2615 Encoder and decoder both deal with `_status_quo_weight_override`. In decoder in happens through the status quo generator run. The problem is when a trial has a `_status_quo_weight_override`, but no status quo. The solution in this diff is to make it impossible (unless you use protected fields directly) to have a `_status_quo_weight_override` without a `status_quo`. ## How could this be wrong? If the user needs to store a status quo weight override on the trial for later but does not yet have a status quo. But I don't know why they could only calculate the weight now and not later. Reviewed By: mgarrard Differential Revision: D60413211
danielcohenlive
force-pushed
the
export-D60413211
branch
from
408826f
to
9dff7f2
Compare
…ebook#2615) Summary: Pull Request resolved: facebook#2615 Encoder and decoder both deal with `_status_quo_weight_override`. In decoder in happens through the status quo generator run. The problem is when a trial has a `_status_quo_weight_override`, but no status quo. The solution in this diff is to make it impossible (unless you use protected fields directly) to have a `_status_quo_weight_override` without a `status_quo`. ## How could this be wrong? If the user needs to store a status quo weight override on the trial for later but does not yet have a status quo. But I don't know why they could only calculate the weight now and not later. Reviewed By: mgarrard Differential Revision: D60413211
|
This pull request was exported from Phabricator. Differential Revision: D60413211 |
danielcohenlive
force-pushed
the
export-D60413211
branch
from
9dff7f2
to
90b3281
Compare
|
This pull request has been merged in abacaea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Encoder and decoder both deal with
_status_quo_weight_override. In decoder in happens through the status quo generator run. The problem is when a trial has a_status_quo_weight_override, but no status quo. The solution in this diff is to make it impossible (unless you use protected fields directly) to have a_status_quo_weight_overridewithout astatus_quo.How could this be wrong?
If the user needs to store a status quo weight override on the trial for later but does not yet have a status quo. But I don't know why they could only calculate the weight now and not later.
Differential Revision: D60413211