Change blob type to str #2624
Closed
Change blob type to str #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Change the blob on AnalysisCard to always be a string rather than Any. This does not change anything for the base Anaysis or MarkdownAnalysis, but changes the dataflow on PlotlyAnalysis to use pio.to_json and pio.from_json during compute (both are very cheap). Doing things this way allows us to decode any AnaysisCard is the same regardless of its subclass and the `card == decoded(encoded))` relatioship holds. Reviewed By: Cesar-Cardoso Differential Revision: D60538382
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60538382 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2624 +/- ##
==========================================
- Coverage 95.23% 95.23% -0.01%
==========================================
Files 492 492
Lines 47697 47683 -14
==========================================
- Hits 45424 45410 -14
Misses 2273 2273 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 430928b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Change the blob on AnalysisCard to always be a string rather than Any. This does not change anything for the base Anaysis or MarkdownAnalysis, but changes the dataflow on PlotlyAnalysis to use pio.to_json and pio.from_json during compute (both are very cheap).
Doing things this way allows us to decode any AnaysisCard is the same regardless of its subclass and the
card == decoded(encoded))relatioship holds.Reviewed By: Cesar-Cardoso
Differential Revision: D60538382