fix bug in UnitX when transforming new search space #2639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60855920 |
Summary: Pull Request resolved: facebook#2639 This fixes a significant bug, where a new search space (other than the search space passed to `UnitX.__init__`) that is passed to `UnitX._transform_search_space` is not actually transformed. A common setting where this comes up is passing a new search space to `Modelbridge.gen` to generate candidates from a particular part of the searchspace. E.g. if the original search space bounds for `x` were [2.0, 5.0] and I want to generate candidates from the restricted search space [3.0, 4.0] by passing a search space to `Modelbridge.gen`, the new search space previously ignored. Reviewed By: mgarrard Differential Revision: D60855920
|
This pull request was exported from Phabricator. Differential Revision: D60855920 |
sdaulton
force-pushed
the
export-D60855920
branch
from
eedc96b
to
ac184d5
Compare
|
This pull request has been merged in c85a803. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes a significant bug, where a new search space (other than the search space passed to
UnitX.__init__) that is passed toUnitX._transform_search_spaceis not actually transformed.A common setting where this comes up is passing a new search space to
Modelbridge.gento generate candidates from a particular part of the searchspace. E.g. if the original search space bounds forxwere [2.0, 5.0] and I want to generate candidates from the restricted search space [3.0, 4.0] by passing a search space toModelbridge.gen, the new search space previously ignored.Differential Revision: D60855920