Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Scheduler.generate_candidates() function #2640

Closed

Conversation

danielcohenlive
Copy link

Summary:
Add Scheduler.generate_candidates() method which calls

  • poll and fetch
  • get next trial
  • eventaully gen report
  • save new trials

Differential Revision: D59606488

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 6, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Aug 7, 2024
Summary:
Pull Request resolved: facebook#2640

Add `Scheduler.generate_candidates()` method which calls
- poll and fetch
- get next trial
- eventaully gen report
- save new trials

Differential Revision: D59606488
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Aug 7, 2024
Summary:
Pull Request resolved: facebook#2640

Add `Scheduler.generate_candidates()` method which calls
- poll and fetch
- get next trial
- eventaully gen report
- save new trials

Differential Revision: D59606488
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Aug 7, 2024
Summary:
Pull Request resolved: facebook#2640

Add `Scheduler.generate_candidates()` method which calls
- poll and fetch
- get next trial
- eventaully gen report
- save new trials

Differential Revision: D59606488
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Aug 7, 2024
Summary:
Pull Request resolved: facebook#2640

Add `Scheduler.generate_candidates()` method which calls
- poll and fetch
- get next trial
- eventaully gen report
- save new trials

Differential Revision: D59606488
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Aug 7, 2024
Summary:
Pull Request resolved: facebook#2640

Add `Scheduler.generate_candidates()` method which calls
- poll and fetch
- get next trial
- eventaully gen report
- save new trials

Differential Revision: D59606488
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Aug 7, 2024
Summary:
Pull Request resolved: facebook#2640

Add `Scheduler.generate_candidates()` method which calls
- poll and fetch
- get next trial
- eventaully gen report
- save new trials

Differential Revision: D59606488
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (837e422) to head (142ff97).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2640      +/-   ##
==========================================
+ Coverage   95.27%   95.28%   +0.01%     
==========================================
  Files         493      493              
  Lines       47640    47746     +106     
==========================================
+ Hits        45388    45497     +109     
+ Misses       2252     2249       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Aug 8, 2024
Summary:
Pull Request resolved: facebook#2640

Add `Scheduler.generate_candidates()` method which calls
- poll and fetch
- get next trial
- eventaully gen report
- save new trials

Differential Revision: D59606488
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Aug 9, 2024
Summary:
Pull Request resolved: facebook#2640

Add `Scheduler.generate_candidates()` method which calls
- poll and fetch
- get next trial
- eventaully gen report
- save new trials

Differential Revision: D59606488
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Aug 9, 2024
Summary:
Pull Request resolved: facebook#2640

Add `Scheduler.generate_candidates()` method which calls
- poll and fetch
- get next trial
- eventaully gen report
- save new trials

Differential Revision: D59606488
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Aug 9, 2024
Summary:
Pull Request resolved: facebook#2640

Add `Scheduler.generate_candidates()` method which calls
- poll and fetch
- get next trial
- eventaully gen report
- save new trials

Differential Revision: D59606488
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

Summary:
Pull Request resolved: facebook#2640

Add `Scheduler.generate_candidates()` method which calls
- poll and fetch
- get next trial
- eventaully gen report
- save new trials

Differential Revision: D59606488
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59606488

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f0e5002.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants