Make SQLAlchemy==1.4.17 a required dependency #2690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2690 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 492 492
Lines 47816 47816
=======================================
Hits 45567 45567
Misses 2249 2249 ☔ View full report in Codecov by Sentry. |
|
Will be fixed by making SQLAlchemy optional again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2660 added SQLAlchemy to AxClient import path, which makes it a required dependency.
Test plan:
Test with minimal dependencies fail on main: https://github.com/facebook/Ax/actions/runs/10509004620
But succeed with this PR: https://github.com/facebook/Ax/actions/runs/10509024361