Merge create_single_objective_problem_from_botorch and create_multi_objective_problem_from_botorch; support constrained MOO #2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61877865 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2722 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 490 490
Lines 47828 47829 +1
=======================================
+ Hits 45631 45633 +2
+ Misses 2197 2196 -1 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D61877865 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 28, 2024
…bjective_problem_from_botorch; support constrained MOO (facebook#2722) Summary: Pull Request resolved: facebook#2722 Context: These functions have a lot of overlapping functionality. Combining them makes it easier to extend their functionality (for example, by supporting constrained MOO). This PR: * Combines `create_single_problem_objective_from_botorch` and `create_multi_objective_problem_from_botorch` into `create_problem_from_botorch` * Reads `lower_is_better` off the test problem -- BoTorch test problems assume minimization unless `negate` is set to True -- instead of requiring the user to pass it (multi-objective problems used to always have lower_is_better=True, so this is more accurate and prevents mismatch) * Adds support for constrained MOO problems from Botorch * Remove stub for constrained MOO problem that only existed to test for an exception that is no longer raised Differential Revision: D61877865
esantorella
force-pushed
the
export-D61877865
branch
from
aa6c931
to
f10b46b
Compare
…bjective_problem_from_botorch; support constrained MOO (facebook#2722) Summary: Pull Request resolved: facebook#2722 Context: These functions have a lot of overlapping functionality. Combining them makes it easier to extend their functionality (for example, by supporting constrained MOO). This PR: * Combines `create_single_problem_objective_from_botorch` and `create_multi_objective_problem_from_botorch` into `create_problem_from_botorch` * Reads `lower_is_better` off the test problem -- BoTorch test problems assume minimization unless `negate` is set to True -- instead of requiring the user to pass it (multi-objective problems used to always have lower_is_better=True, so this is more accurate and prevents mismatch) * Adds support for constrained MOO problems from Botorch * Remove stub for constrained MOO problem that only existed to test for an exception that is no longer raised Reviewed By: Balandat Differential Revision: D61877865
|
This pull request was exported from Phabricator. Differential Revision: D61877865 |
esantorella
force-pushed
the
export-D61877865
branch
from
f10b46b
to
d691527
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 29, 2024
…bjective_problem_from_botorch; support constrained MOO (facebook#2722) Summary: Pull Request resolved: facebook#2722 Context: These functions have a lot of overlapping functionality. Combining them makes it easier to extend their functionality (for example, by supporting constrained MOO). This PR: * Combines `create_single_problem_objective_from_botorch` and `create_multi_objective_problem_from_botorch` into `create_problem_from_botorch` * Reads `lower_is_better` off the test problem -- BoTorch test problems assume minimization unless `negate` is set to True -- instead of requiring the user to pass it (multi-objective problems used to always have lower_is_better=True, so this is more accurate and prevents mismatch) * Adds support for constrained MOO problems from Botorch * Remove stub for constrained MOO problem that only existed to test for an exception that is no longer raised Differential Revision: D61877865 Reviewed By: Balandat
|
This pull request has been merged in 6a9ef95. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: These functions have a lot of overlapping functionality. Combining them makes it easier to extend their functionality (for example, by supporting constrained MOO).
This PR:
create_single_problem_objective_from_botorchandcreate_multi_objective_problem_from_botorchintocreate_problem_from_botorchlower_is_betteroff the test problem -- BoTorch test problems assume minimization unlessnegateis set to True -- instead of requiring the user to pass it (multi-objective problems used to always have lower_is_better=True, so this is more accurate and prevents mismatch)Differential Revision: D61877865