remove unused metrics #2728
Closed
remove unused metrics #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61998254 |
|
This pull request was exported from Phabricator. Differential Revision: D61998254 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#2728 These may have once been used for benchmarking, but no longer are (not even in tests). Also, if these were to become needed again, it should be possible to define one metric based on BoTorch test functions that covers most of these, so we don't need so many classes that need their own registry entries. Also removed Sphinx headings for metrics files that aren't in Ax. * Removed Sphinx headings for BoTorch Test Problem and Dictionary Lookup, which don't exist anymore * Removed Hartmann6Metric, JenattonMetric, AugmentedBraninMetric, AugmentedhartmannMetric * Removed functionality from stubs that wasn't being used Differential Revision: D61998254
esantorella
force-pushed
the
export-D61998254
branch
from
3914867
to
e6f6063
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2728 +/- ##
==========================================
+ Coverage 95.42% 95.46% +0.04%
==========================================
Files 490 489 -1
Lines 47872 47835 -37
==========================================
- Hits 45681 45668 -13
+ Misses 2191 2167 -24 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D61998254 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 30, 2024
Summary: Pull Request resolved: facebook#2728 These may have once been used for benchmarking, but no longer are (not even in tests). Also, if these were to become needed again, it should be possible to define one metric based on BoTorch test functions that covers most of these, so we don't need so many classes that need their own registry entries. Also removed Sphinx headings for metrics files that aren't in Ax. * Removed Sphinx headings for BoTorch Test Problem and Dictionary Lookup, which don't exist anymore * Removed Hartmann6Metric, JenattonMetric, AugmentedBraninMetric, AugmentedhartmannMetric * Removed functionality from stubs that wasn't being used Differential Revision: D61998254
esantorella
force-pushed
the
export-D61998254
branch
from
e6f6063
to
c98c625
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61998254 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 30, 2024
Summary: Pull Request resolved: facebook#2728 These may have once been used for benchmarking, but no longer are (not even in tests). Also, if these were to become needed again, it should be possible to define one metric based on BoTorch test functions that covers most of these, so we don't need so many classes that need their own registry entries. Also removed Sphinx headings for metrics files that aren't in Ax. * Removed Sphinx headings for BoTorch Test Problem and Dictionary Lookup, which don't exist anymore * Removed Hartmann6Metric, JenattonMetric, AugmentedBraninMetric, AugmentedhartmannMetric * Removed functionality from stubs that wasn't being used Differential Revision: D61998254
esantorella
force-pushed
the
export-D61998254
branch
from
c98c625
to
1e20d51
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61998254 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 30, 2024
Summary: Pull Request resolved: facebook#2728 These may have once been used for benchmarking, but no longer are (not even in tests). Also, if these were to become needed again, it should be possible to define one metric based on BoTorch test functions that covers most of these, so we don't need so many classes that need their own registry entries. Also removed Sphinx headings for metrics files that aren't in Ax. * Removed Sphinx headings for BoTorch Test Problem and Dictionary Lookup, which don't exist anymore * Removed Hartmann6Metric, JenattonMetric, AugmentedBraninMetric, AugmentedhartmannMetric * Removed functionality from stubs that wasn't being used Differential Revision: D61998254
esantorella
force-pushed
the
export-D61998254
branch
from
1e20d51
to
232892e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61998254 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 30, 2024
Summary: Pull Request resolved: facebook#2728 These may have once been used for benchmarking, but no longer are (not even in tests). Also, if these were to become needed again, it should be possible to define one metric based on BoTorch test functions that covers most of these, so we don't need so many classes that need their own registry entries. Also removed Sphinx headings for metrics files that aren't in Ax. * Removed Sphinx headings for BoTorch Test Problem and Dictionary Lookup, which don't exist anymore * Removed Hartmann6Metric, JenattonMetric, AugmentedBraninMetric, AugmentedhartmannMetric * Removed functionality from stubs that wasn't being used Differential Revision: D61998254
esantorella
force-pushed
the
export-D61998254
branch
from
232892e
to
0fb6237
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61998254 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 30, 2024
Summary: Pull Request resolved: facebook#2728 These may have once been used for benchmarking, but no longer are (not even in tests). Also, if these were to become needed again, it should be possible to define one metric based on BoTorch test functions that covers most of these, so we don't need so many classes that need their own registry entries. Also removed Sphinx headings for metrics files that aren't in Ax. * Removed Sphinx headings for BoTorch Test Problem and Dictionary Lookup, which don't exist anymore * Removed Hartmann6Metric, JenattonMetric, AugmentedBraninMetric, AugmentedhartmannMetric * Removed functionality from stubs that wasn't being used Differential Revision: D61998254
esantorella
force-pushed
the
export-D61998254
branch
from
0fb6237
to
445ff3d
Compare
Summary: Pull Request resolved: facebook#2728 These may have once been used for benchmarking, but no longer are (not even in tests). Also, if these were to become needed again, it should be possible to define one metric based on BoTorch test functions that covers most of these, so we don't need so many classes that need their own registry entries. Also removed Sphinx headings for metrics files that aren't in Ax. * Removed Sphinx headings for BoTorch Test Problem and Dictionary Lookup, which don't exist anymore * Removed JenattonMetric, AugmentedBraninMetric, AugmentedHartmannMetric * Removed functionality from stubs that wasn't being used Differential Revision: D61998254
|
This pull request was exported from Phabricator. Differential Revision: D61998254 |
esantorella
force-pushed
the
export-D61998254
branch
from
445ff3d
to
d511a1e
Compare
|
This pull request has been merged in b2d4940. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These may have once been used for benchmarking, but no longer are (not even in tests). Also, if these were to become needed again, it should be possible to define one metric based on BoTorch test functions that covers most of these, so we don't need so many classes that need their own registry entries.
Also removed Sphinx headings for metrics files that aren't in Ax.
Differential Revision: D61998254