make debugging easier by saying which constraint is bad #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Would have made debugging this problem way easier https://fb.workplace.com/groups/ae.feedback/posts/8591041154263824/?comment_id=8591648994203040&reply_comment_id=8591748957526377 Generally if there are a bunch of constraints, it's helpful to let the user know which constraint we have a problem with. Differential Revision: D62154912
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62154912 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2737 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 489 489
Lines 47859 47861 +2
=======================================
+ Hits 45693 45695 +2
Misses 2166 2166 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in e105438. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Would have made debugging this problem way easier https://fb.workplace.com/groups/ae.feedback/posts/8591041154263824/?comment_id=8591648994203040&reply_comment_id=8591748957526377
Generally if there are a bunch of constraints, it's helpful to let the user know which constraint we have a problem with.
Differential Revision: D62154912