Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform batch to new sq #2755

Closed
wants to merge 1 commit into from
Closed

Conversation

sdaulton
Copy link
Contributor

@sdaulton sdaulton commented Sep 9, 2024

Summary: Implement transform for scaling batches to the same SQ.

Reviewed By: ItsMrLin

Differential Revision: D62266853

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 9, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62266853

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 98.08917% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.60%. Comparing base (4b54cc5) to head (a428b69).

Files with missing lines Patch % Lines
ax/modelbridge/transforms/relativize.py 90.90% 2 Missing ⚠️
ax/modelbridge/transforms/transform_to_new_sq.py 98.41% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2755      +/-   ##
==========================================
+ Coverage   95.58%   95.60%   +0.01%     
==========================================
  Files         487      489       +2     
  Lines       47775    47903     +128     
==========================================
+ Hits        45668    45796     +128     
  Misses       2107     2107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62266853

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Sep 9, 2024
Summary:
Pull Request resolved: facebook#2755

Implement transform for scaling batches to the same SQ.

Reviewed By: ItsMrLin

Differential Revision: D62266853
Summary:
Pull Request resolved: facebook#2755

Implement transform for scaling batches to the same SQ.

Reviewed By: ItsMrLin

Differential Revision: D62266853
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62266853

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9658082.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants