Remove Models.ST_MTGP_LEGACY & _NEHVI #3031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Deprecates `Models.MOO` and points it to `Models.BOTORCH_MODULAR` for backwards compatibility. Differential Revision: D65550955
Summary: Cleaning up legacy model entries and updating them to point to the MBM variant of `Models.ST_MTGP` to retain backwards compatibility. Also cleaned up a few references of `Models.FULLYBAYESIAN...` while at it. These all point to corresponding MBM models already. Differential Revision: D65568608
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65568608 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3031 +/- ##
==========================================
- Coverage 95.60% 95.58% -0.02%
==========================================
Files 483 483
Lines 49112 49095 -17
==========================================
- Hits 46954 46928 -26
- Misses 2158 2167 +9 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 22bd1b2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cleaning up legacy model entries and updating them to point to the MBM variant of
Models.ST_MTGPto retain backwards compatibility.Also cleaned up a few references of
Models.FULLYBAYESIAN...while at it. These all point to corresponding MBM models already.Differential Revision: D65568608