Skip to content

Commit

Permalink
cut remaining occurrences of names ReadHolder, WriteHolder
Browse files Browse the repository at this point in the history
Summary: With one exception, they are all unused now that all uses have been replaced by direct use of `std::unique_lock` for `WriteHolder` and `std::shared_lock` for `ReadHolder`.

Differential Revision: D53491909

fbshipit-source-id: 7f8f4ba878799c9142c442b62950d0dd605683f8
  • Loading branch information
yfeldblum authored and facebook-github-bot committed Feb 7, 2024
1 parent d617cd0 commit 5731199
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions cachelib/common/Mutex.h
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,6 @@ class PThreadSpinLock {
// to template between using a RW mutex and a mutex
struct RWMockLock {
using Lock = folly::MicroSpinLock;
using ReadHolder = std::shared_lock<RWMockLock>;
using WriteHolder = std::unique_lock<RWMockLock>;

void lock() { l_.lock(); }
bool try_lock() { return l_.try_lock(); }
Expand Down

0 comments on commit 5731199

Please sign in to comment.