-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for M1 chips #2684
base: main
Are you sure you want to change the base?
Add support for M1 chips #2684
Conversation
@marcesengel Hey Marc, what java version should I use with this while Facebook works on merging this? |
Updated jna, java-objc-bridge, sqlite-jdbc and zstd-jni to supported version Breaks java 8 support due to java-objc-bridge bump shannah/Java-Objective-C-Bridge#41 (comment)
Hey @marcesengel I would love to see this moving forward. Could you update the CircleCI config to install JDK 11: Lines 47 to 57 in 16dc486
and update the https://github.com/facebook/buck/blob/main/.circleci/config.yml#L200 To point to JDK 11? |
@marcesengel are you still working on this? Or would you mind if someone else took this over? |
This PR only allows us to build on M1 IIRC, not sure if everything works with that build though - I still had some issues building react-native with the resulting build of buck. I'd be open to pass this on, as it sadly wasn't getting any contributor traction when I had the time and need to add support (which I can understand, people have a life outside open source). |
Totally understand :) I'll take this over then 🙏 |
Just a heads up that I won't have capacity to do this one. I looked into it but it's harder than expected + we dropped support for Buck 1 OSS on React Native as we're looking into potentially adopting Buck 2 |
Fixes #2666. Updated
jna
,java-objc-bridge
,sqlite-jdbc
andzstd-jni
to supported versions.Breaks java 8 support due to bumping
java-objc-bridge
, see shannah/Java-Objective-C-Bridge#41 (comment).