This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Fix dev branch CircleCI #2715
Open
Fix dev branch CircleCI #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, all dev publish_docs jobs are failing the Java 11 requirement (https://github.com/facebook/buck/blob/dev/build.xml#L365-L367 ). A lot of things need to be changed to pass that requirement: - Install OpenJDK 11 instead of 8 - Install new Android command-line tools. The old SDK tools don't support JDK 8 (https://stackoverflow.com/a/65782803 ). Oddly, the *new* tools don't install to the right location (https://stackoverflow.com/a/67413427 ), so they need to be moved around a little before they'll work. - Install Python 3.9.4 (required by Ant) - Build Buck! Release-branch builds require Java 8, so we can't use those and hope to pass the version check. - Pass down our local Buck executable to docs/publish.sh and docs/soyweb-prod.sh. By default, these scripts will try to use the Ant-bootstrapped Java 8 Buck instead of our locally built Java 11 Buck. This has been tested by adding a couple tweaks in a separate branch (https://github.com/egpast/buck/commits/dev-force-circleci ) to force publish_docs to run on commits and stop it from actually publishing, and then confirming that CircleCI passes (https://app.circleci.com/pipelines/github/egpast/buck/25/workflows/b049df7e-9e0c-49a8-95d5-eee82aeb40bc/jobs/17 ).
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Summary: Currently, all `dev` branch `publish_docs` jobs are failing [the Java 11 requirement](https://github.com/facebook/buck/blob/dev/build.xml#L365-L367). A lot of things need to be changed to pass that requirement: - Install OpenJDK 11 instead of 8 - Install new Android command-line tools. [The old SDK tools don't support JDK 8](https://stackoverflow.com/a/65782803). Oddly, [the *new* tools don't install to the right location](https://stackoverflow.com/a/67413427), so they need to be moved around a little before they'll work. - Install Python 3.9.4 (required by Ant) - Build Buck! Release-branch builds require Java 8, so we can't use those and hope to pass the version check. - Pass down our local Buck executable to `docs/publish.sh` and `docs/soyweb-prod.sh`. Otherwise, these scripts will try to use the Ant-bootstrapped Java 8 Buck instead of our locally built Java 11 Buck. They'll still use `buck` by default, so local usage is unaffected. This has been tested by adding a couple tweaks in [a separate branch](https://github.com/egpast/buck/commits/dev-force-circleci) to force `publish_docs` to run on commits and stop it from actually publishing, and then confirming that [CircleCI passes](https://app.circleci.com/pipelines/github/egpast/buck/25/workflows/b049df7e-9e0c-49a8-95d5-eee82aeb40bc/jobs/17). Pull Request resolved: #2715 Reviewed By: zpao Pulled By: egpast fbshipit-source-id: 8163a70188978814c3726c560653079f43fe901a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all
devbranchpublish_docsjobs are failing the Java 11 requirement.A lot of things need to be changed to pass that requirement:
docs/publish.shanddocs/soyweb-prod.sh. Otherwise, these scripts will try to use the Ant-bootstrapped Java 8 Buck instead of our locally built Java 11 Buck. They'll still usebuckby default, so local usage is unaffected.This has been tested by adding a couple tweaks in a separate branch to force
publish_docsto run on commits and stop it from actually publishing, and then confirming that CircleCI passes.