Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

allow buck to be built at newer version of Python #2740

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dagitses
Copy link

@dagitses dagitses commented May 4, 2023

allow buck to be built at newer version of Python

Summary:
See #2696 for another example.

In Python 3.3 types like Sequence were moved to the
collections.abc submodule. The aforementioned PR fixed runtime
issues, but the bin/buck Python bootstrapping script still failed with
non-ancient versions of Python.

Test Plan: Built and ran buck1 successfully on my machine.

Summary:
See facebook#2696 for another example.

In Python 3.3 types like `Sequence` were moved to the
`collections.abc` submodule. The aforementioned PR fixed runtime
issues, but the bin/buck Python bootstrapping script still failed with
non-ancient versions of Python.

Test Plan: Built and ran buck1 successfully on my machine.
@stepancheg
Copy link
Contributor

Buck1 is officially dead.

From readme:

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants