Skip to content

Commit

Permalink
remove min_version and target_sdk_version from apple_toolchain
Browse files Browse the repository at this point in the history
Summary: These attributes are not in use, they have been superseded by the ones in cxx_toolchain.

Reviewed By: manicaesar

Differential Revision: D59826043

fbshipit-source-id: 81186e1ce6abfceae78aaecd435c6b5e09e4198f
  • Loading branch information
rmaz authored and facebook-github-bot committed Jul 26, 2024
1 parent 331b50e commit 4b43f69
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions apple/apple_rules_impl.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,6 @@ extra_attributes = {
"libtool": attrs.exec_dep(providers = [RunInfo]),
"lipo": attrs.exec_dep(providers = [RunInfo]),
"mapc": attrs.option(attrs.exec_dep(providers = [RunInfo]), default = None),
"min_version": attrs.string(),
"momc": attrs.exec_dep(providers = [RunInfo]),
"objdump": attrs.option(attrs.exec_dep(providers = [RunInfo]), default = None),
# A placeholder tool that can be used to set up toolchain constraints.
Expand All @@ -222,10 +221,6 @@ extra_attributes = {
"requires_xcode_version_match": attrs.bool(default = False),
"sdk_path": attrs.option(attrs.source(), default = None), # Mark as optional until we remove `_internal_sdk_path`
"swift_toolchain": attrs.option(attrs.toolchain_dep(), default = None),
# The requested deployment target for a build. This will be used to
# form the versioned target triple when building, and compared with
# each build rule's target_sdk_version to ensure compatibility.
"target_sdk_version": attrs.option(attrs.string(), default = None),
"version": attrs.option(attrs.string(), default = None),
"xcode_build_version": attrs.option(attrs.string(), default = None),
"xcode_version": attrs.option(attrs.string(), default = None),
Expand Down

0 comments on commit 4b43f69

Please sign in to comment.