Revert "Refactor dep rewriting logic in github shims" #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Broke oss buck2 CI. buck2 does some path remapping that was not tested against in the initial diff. The right way to handle this looks complex and will take some time to implement, so reverting the changes in the interim. Original commit changeset: 2cdf2fc1cbce Original Phabricator Diff: D62896839 Differential Revision: D63152891
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63152891 |
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebook/buck2#782 Broke oss buck2 CI. buck2 does some path remapping that was not tested against in the initial diff. The right way to handle this looks complex and will take some time to implement, so reverting the changes in the interim. Original commit changeset: 2cdf2fc1cbce Original Phabricator Diff: D62896839 Reviewed By: zpao Differential Revision: D63152891 fbshipit-source-id: 53aad436fdca15bece88b5ad0c12ea11390fb3f8
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebook/buck2#782 Broke oss buck2 CI. buck2 does some path remapping that was not tested against in the initial diff. The right way to handle this looks complex and will take some time to implement, so reverting the changes in the interim. Original commit changeset: 2cdf2fc1cbce Original Phabricator Diff: D62896839 Reviewed By: zpao Differential Revision: D63152891 fbshipit-source-id: 53aad436fdca15bece88b5ad0c12ea11390fb3f8
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebook/buck2#782 Broke oss buck2 CI. buck2 does some path remapping that was not tested against in the initial diff. The right way to handle this looks complex and will take some time to implement, so reverting the changes in the interim. Original commit changeset: 2cdf2fc1cbce Original Phabricator Diff: D62896839 Reviewed By: zpao Differential Revision: D63152891 fbshipit-source-id: 53aad436fdca15bece88b5ad0c12ea11390fb3f8
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebook/buck2#782 Broke oss buck2 CI. buck2 does some path remapping that was not tested against in the initial diff. The right way to handle this looks complex and will take some time to implement, so reverting the changes in the interim. Original commit changeset: 2cdf2fc1cbce Original Phabricator Diff: D62896839 Reviewed By: zpao Differential Revision: D63152891 fbshipit-source-id: 53aad436fdca15bece88b5ad0c12ea11390fb3f8
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebook/buck2#782 Broke oss buck2 CI. buck2 does some path remapping that was not tested against in the initial diff. The right way to handle this looks complex and will take some time to implement, so reverting the changes in the interim. Original commit changeset: 2cdf2fc1cbce Original Phabricator Diff: D62896839 Reviewed By: zpao Differential Revision: D63152891 fbshipit-source-id: 53aad436fdca15bece88b5ad0c12ea11390fb3f8
|
This pull request has been merged in edb0830. |
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebook/buck2#782 Broke oss buck2 CI. buck2 does some path remapping that was not tested against in the initial diff. The right way to handle this looks complex and will take some time to implement, so reverting the changes in the interim. Original commit changeset: 2cdf2fc1cbce Original Phabricator Diff: D62896839 Reviewed By: zpao Differential Revision: D63152891 fbshipit-source-id: 53aad436fdca15bece88b5ad0c12ea11390fb3f8
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebook/buck2#782 Broke oss buck2 CI. buck2 does some path remapping that was not tested against in the initial diff. The right way to handle this looks complex and will take some time to implement, so reverting the changes in the interim. Original commit changeset: 2cdf2fc1cbce Original Phabricator Diff: D62896839 Reviewed By: zpao Differential Revision: D63152891 fbshipit-source-id: 53aad436fdca15bece88b5ad0c12ea11390fb3f8
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebook/buck2#782 Broke oss buck2 CI. buck2 does some path remapping that was not tested against in the initial diff. The right way to handle this looks complex and will take some time to implement, so reverting the changes in the interim. Original commit changeset: 2cdf2fc1cbce Original Phabricator Diff: D62896839 Reviewed By: zpao Differential Revision: D63152891 fbshipit-source-id: 53aad436fdca15bece88b5ad0c12ea11390fb3f8
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Sep 21, 2024
Summary: X-link: facebook/buck2#782 Broke oss buck2 CI. buck2 does some path remapping that was not tested against in the initial diff. The right way to handle this looks complex and will take some time to implement, so reverting the changes in the interim. Original commit changeset: 2cdf2fc1cbce Original Phabricator Diff: D62896839 Reviewed By: zpao Differential Revision: D63152891 fbshipit-source-id: 53aad436fdca15bece88b5ad0c12ea11390fb3f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Broke oss buck2 CI. buck2 does some path remapping that was not tested against
in the initial diff. The right way to handle this looks complex and will take
some time to implement, so reverting the changes in the interim.
Original commit changeset: 2cdf2fc1cbce
Original Phabricator Diff: D62896839
Differential Revision: D63152891