Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation for the proxy configuration explains globs while regexps are used to match paths #3184

Closed
robertpanzer opened this issue Sep 25, 2017 · 0 comments

Comments

@robertpanzer
Copy link
Contributor

robertpanzer commented Sep 25, 2017

The documentation for the proxy configuration [1] explains that paths can be matched with glob expressions.
But looking at [2] it seems to me that the proxy uses regexps to match the path.
(Also in my project I got an error using ** and globs don't work)

[1] https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#configuring-the-proxy-manually
[2] https://github.com/facebookincubator/create-react-app/blob/c00358376b50e44313671384c64faf420e8d0c0a/packages/react-dev-utils/WebpackDevServerUtils.js#L367

Edit: Updated URL [2] to use a fix commit instead of referring to master which might end up in Nirvana

robertpanzer pushed a commit to robertpanzer/create-react-app that referenced this issue Sep 25, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant