-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint warnings and errors ignored in npm run build #440
Comments
PR is welcome, I didn't really test this well. |
Do you think the build should fail? |
Maybe fail when there are errors and pass if there are only warnings? |
We have no errors in the lint config (on purpose). And we only use warnings for stuff that really hints at possible errors (i.e. no style rules). So I think it might be better to fail. |
Ah, that makes sense. I also noticed that in |
Sounds good. |
I think this was fixed since. |
To reproduce:
Output:
But if you run
npm run build
:Tested with 0.2.1
The reason is explained here:
stats.errors
andstats.warnings
are checked instart.js
butbuild.js
only checks forerr
.I may be able to submit a PR for this if needed.
The text was updated successfully, but these errors were encountered: