Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated comments on react-refresh #10784

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Remove outdated comments on react-refresh #10784

merged 3 commits into from
Apr 12, 2021

Conversation

cdtkrk
Copy link
Contributor

@cdtkrk cdtkrk commented Apr 6, 2021

Related Issue: #9984

EDITED:
See #10784 (comment)


Without FAST_REFRESH=false, auto reload on src/index.js does not work.

According to comment, react-refresh should be disabled by default.
This commit changes default value of process.env.FAST_REFRESH.

For testing
$ yarn create-react-app path/to/app.
Edit path/to/app/src/index.js.

@facebook-github-bot
Copy link

Hi @kidkkr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@petetnt
Copy link
Contributor

petetnt commented Apr 6, 2021

Hi @kidkkr,

the FAST_REFRESH support is stable, but the comment has not been updated (it was merged as experimental in #8582 and rolled out as stable in 4.0.0.). The comment should be removed or updated accordingly.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@cdtkrk
Copy link
Contributor Author

cdtkrk commented Apr 6, 2021

Okay, @petetnt ! Would you mind if I remove comments in this PR instead?

@cdtkrk cdtkrk changed the title Fix default value of FAST_REFRESH to false Remove outdated comments on react-refresh Apr 6, 2021
@ianschmitz ianschmitz merged commit fddce8a into facebook:master Apr 12, 2021
wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
sumanthratna pushed a commit to sumanthratna/create-react-app that referenced this pull request Aug 4, 2021
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants