-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve dependency issues #11751
base: main
Are you sure you want to change the base?
Conversation
is there any deadline for this version 5.0.1? |
+1 |
How to use it before release? |
Add the missing dependency in your Additionally, I did |
7076f9d
to
6807108
Compare
Anyone know how I can use this before release with pnpm? I am seeing errors with @babel/plugin-proposal-private-property-in-object |
9731d78
to
3a1eb28
Compare
@@ -143,9 +143,9 @@ module.exports = function (webpackEnv) { | |||
config: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also need to specify the path to the postcss:
{
// Options for PostCSS as we reference these options twice
// Adds vendor prefixing based on your specified browser support in
// package.json
loader: require.resolve('postcss-loader'),
implementation: require.resolve("postcss"),
options: {
postcssOptions: {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not necessary, postcss-loader
declares postcss
as a peer dependency so it will get it from the parent (react-scripts
) on its own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your reply, the problem I'm having is that under node_modules
is postcss v7
, but plugins like postcss-flexbugs-fixes
depend on postcss v8
, which causes errors when compiling.
So I think it might be better to specify implementation.
…vate-property-in-object`
3a1eb28
to
074bf9c
Compare
Could this be merged? |
Issue still existing, can this be merged? |
Can this fix be merged? |
News on this? |
I'm pretty sure this project is no longer maintained |
I think you right. |
What's the problem this PR addresses?
The project created by
[email protected]
has dependency issues.How did you fix it?
@babel/plugin-proposal-private-property-in-object
as a dependency tobabel-preset-react-app
@types/testing-library__jest-dom
to the typescript template to fix typechecking under strict dependency environmentsrequire.resolve
the PostCSS pluginsrequire.resolve
the Jest watch pluginstypescript
as an optional peer dependency toeslint-config-react-app