Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve dependency issues #11751

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Dec 14, 2021

What's the problem this PR addresses?

The project created by [email protected] has dependency issues.

How did you fix it?

  • Add @babel/plugin-proposal-private-property-in-object as a dependency to babel-preset-react-app
  • Add @types/testing-library__jest-dom to the typescript template to fix typechecking under strict dependency environments
  • require.resolve the PostCSS plugins
  • require.resolve the Jest watch plugins
  • Add typescript as an optional peer dependency to eslint-config-react-app

@giulianf
Copy link

is there any deadline for this version 5.0.1?

@AndyDyer
Copy link

+1

@aramis-it
Copy link

How to use it before release?

@blu3r4y
Copy link

blu3r4y commented Jan 6, 2022

How to use it before release?

Add the missing dependency in your .yarnrc.yml file, see the comment by @llimos here: #11793 (comment)

Additionally, I did yarn add -D @types/testing-library__jest-dom to also fix typechecking errors.

@merceyz merceyz changed the title fix: add missing dependencies fix: resolve dependency issues Jan 24, 2022
@merceyz merceyz force-pushed the merceyz/fix/missing-dependencies branch from 7076f9d to 6807108 Compare January 24, 2022 13:48
@jakeklassen
Copy link

Anyone know how I can use this before release with pnpm? I am seeing errors with @babel/plugin-proposal-private-property-in-object

@@ -143,9 +143,9 @@ module.exports = function (webpackEnv) {
config: false,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also need to specify the path to the postcss:

 {
        // Options for PostCSS as we reference these options twice
        // Adds vendor prefixing based on your specified browser support in
        // package.json
        loader: require.resolve('postcss-loader'),
        implementation: require.resolve("postcss"),
        options: {
          postcssOptions: {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not necessary, postcss-loader declares postcss as a peer dependency so it will get it from the parent (react-scripts) on its own.

Copy link

@await-ovo await-ovo Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply, the problem I'm having is that under node_modules is postcss v7, but plugins like postcss-flexbugs-fixes depend on postcss v8, which causes errors when compiling.

So I think it might be better to specify implementation.

@merceyz merceyz force-pushed the merceyz/fix/missing-dependencies branch from 3a1eb28 to 074bf9c Compare December 11, 2022 13:18
@indutny
Copy link

indutny commented Feb 17, 2023

Could this be merged?

@hellenfc
Copy link

Issue still existing, can this be merged?

@MuyangAmigo
Copy link

Can this fix be merged?

@briandiaz
Copy link

News on this?

@duereg
Copy link

duereg commented Sep 12, 2023

I'm pretty sure this project is no longer maintained

@giulianf
Copy link

I'm pretty sure this project is no longer maintained

I think you right.
Maybe there is an alternative? It's worrying to see such project not followed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

babel-preset-react-app dependency error - Yarn 3