Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make node version check more robust in e2e.sh #1295

Merged
merged 1 commit into from
Feb 13, 2017

Commits on Feb 13, 2017

  1. Make node version check more robust in e2e.sh

    I noticed that when running `./tasks/e2e.sh`, the node version check was
    failing to execute properly due to bash complaining (version
    '3.2.57(1)-release' on my Mac OSX machine). Once I changed the test syntax
    to use '[[', I found that sed wasn't stripping the node version correctly.
    I verified this with:
    
        nvm use 0.10
        ./tasks/e2e.sh
    
    ...which bombed out on a 'const' declaration'. It's probably down to some
    platform peculiarities, but good to fix them nonetheless.
    pugnascotia committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    b558514 View commit details
    Browse the repository at this point in the history