Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix- react-scripts build doesn't allow for specified path #1362

Closed
wants to merge 2 commits into from
Closed

Fix- react-scripts build doesn't allow for specified path #1362

wants to merge 2 commits into from

Conversation

ajayy004
Copy link

@ajayy004 ajayy004 commented Jan 9, 2017

#1354 Fix

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@gaearon
Copy link
Contributor

gaearon commented Jan 9, 2017

Thanks for the PR! We won’t be taking this yet. Allowing to customize path is on our list of user requests, but we won’t be introducing more configuration on a case-by-case basis. We might add support for a configuration file at some point, but not now. Nevertheless I appreciate the time you took to contribute.

@gaearon gaearon closed this Jan 9, 2017
@tuchk4 tuchk4 mentioned this pull request Jan 27, 2017
@tabbi89
Copy link

tabbi89 commented Apr 15, 2017

thanks for the answer @gaearon, but more detailed reason why not ?

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants